Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/ethapi, accounts/abi/bind: use errors.Is for error comparison #28348

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

bnovil
Copy link
Contributor

@bnovil bnovil commented Oct 16, 2023

No description provided.

@lightclient lightclient changed the title internal/ethapi: enhance error check internal/ethapi,simulated_backend: use errors.Is for error comparison Oct 16, 2023
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the error would ever be wrapped in this chain, but seems good to consistently use errors.Is.

@holiman holiman added this to the 1.13.5 milestone Oct 17, 2023
@holiman holiman changed the title internal/ethapi,simulated_backend: use errors.Is for error comparison internal/ethapi, accounts/abi/bind: use errors.Is for error comparison Oct 17, 2023
@holiman holiman merged commit f62502e into ethereum:master Oct 17, 2023
1 of 2 checks passed
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
…son (ethereum#28348)


Co-authored-by: lightclient <lightclient@protonmail.com>
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Dergarcon pushed a commit to specialmechanisms/mev-geth-0x2mev that referenced this pull request Jan 31, 2024
…son (ethereum#28348)


Co-authored-by: lightclient <lightclient@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants